deps-dev: Bump @playwright/test to ~1.53.2
#16803
Open
+124
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Jul 3, 2025
| @@ -4,10 +4,4 @@ window.Sentry = Sentry; | |||
|
|
|||
| Sentry.init({ | |||
| dsn: 'https://public@dsn.ingest.sentry.io/1337', | |||
| transportOptions: { | |||
There was a problem hiding this comment.
these are no longer needed because this was fixed in a playwright update
mydea
force-pushed
the
fn/update-playwright-2
branch
from
da3fafb to
ddc5a2b
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Missing Sentry Test Utils in SolidStart E2E Tests
The @sentry-internal/test-utils dependency was accidentally removed from the devDependencies of four SolidStart e2e test applications (solidstart-top-level-import, solidstart, solidstart-dynamic-import, solidstart-spa) during a Playwright version upgrade. This dependency is crucial for test utilities, and its removal, inconsistent with other similar test applications, will likely break tests.
dev-packages/e2e-tests/test-applications/solidstart-top-level-import/package.json#L16-L19
dev-packages/e2e-tests/test-applications/solidstart/package.json#L16-L19
dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/package.json#L16-L19
dev-packages/e2e-tests/test-applications/solidstart-spa/package.json#L16-L19
Was this report helpful? Give feedback by reacting with 👍 or 👎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates this so we get newest browsers etc. Also aligns version everywhere again.